-----Original Message----- From: Jason Gunthorpe <jgg@xxxxxxxx> Sent: Thursday, December 19, 2019 9:07 PM To: Leon Romanovsky <leon@xxxxxxxxxx> Cc: Doug Ledford <dledford@xxxxxxxxxx>; Leon Romanovsky <leonro@xxxxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>; Artemy Kovalyov <artemyko@xxxxxxxxxxxx>; Aviad Yehezkel <aviadye@xxxxxxxxxxxx>; Yishai Hadas <yishaih@xxxxxxxxxxxx> Subject: Re: [PATCH rdma-rc 1/3] IB/mlx5: Unify ODP MR code paths to allow extra flexibility On Thu, Dec 19, 2019 at 03:46:44PM +0200, Leon Romanovsky wrote: > From: Artemy Kovalyov <artemyko@xxxxxxxxxxxx> > > Building MR translation table in ODP case requires additional > flexibility, namely random access to DMA addresses. Make both direct > and indirect ODP MR use same code path, separated from non-ODP MR code path. > > Fixes: d2183c6f1958 ("RDMA/umem: Move page_shift from ib_umem to > ib_odp_umem") What does it fix? AK: fix huge page ODP MR handling, was broken in __mlx5_ib_populate_pas shift calculation Jason