b0ffeb537f3a changed the way how outstanding WRs are tracked for GSI QP. But the fix did not cover the case when a call to ib_post_send fails and index to track outstanding WRs need to be updated correctly. Fixes: b0ffeb537f3a ('IB/mlx5: Fix iteration overrun in GSI qps ') Signed-off-by: Prabhath Sajeepa <psajeepa@xxxxxxxxxxxxxxx> --- drivers/infiniband/hw/mlx5/gsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/gsi.c b/drivers/infiniband/hw/mlx5/gsi.c index ac4d8d1..1ae6fd9 100644 --- a/drivers/infiniband/hw/mlx5/gsi.c +++ b/drivers/infiniband/hw/mlx5/gsi.c @@ -507,8 +507,7 @@ int mlx5_ib_gsi_post_send(struct ib_qp *qp, const struct ib_send_wr *wr, ret = ib_post_send(tx_qp, &cur_wr.wr, bad_wr); if (ret) { /* Undo the effect of adding the outstanding wr */ - gsi->outstanding_pi = (gsi->outstanding_pi - 1) % - gsi->cap.max_send_wr; + gsi->outstanding_pi--; goto err; } spin_unlock_irqrestore(&gsi->lock, flags); -- 2.7.4