I am happy to make a larger/functional change. From what I read, desired patch scope is proportional to linux community involvement but if that not how you guys do the infiniband driver that fine. Whats a feature you guys want but no one is working on yet, or rather where is such a list kept? On Thu, Dec 12, 2019 at 7:10 AM Gal Pressman <galpress@xxxxxxxxxx> wrote: > > On 12/12/2019 10:49, Leon Romanovsky wrote: > > On Wed, Dec 11, 2019 at 12:26:54PM -0400, Jason Gunthorpe wrote: > >> On Wed, Dec 11, 2019 at 11:16:26AM +0000, Max Hirsch wrote: > >>> When running checkpatch on cma.c the following error was found: > >> > >> I think checkpatch will complain about your patch, did you run it? > > > > Jason, Doug > > > > I would like to ask to refrain from accepting checkpatch.pl patches > > which are not part of other large submission. Such standalone cleanups > > do more harm than actual benefit from them for old and more or less > > stable code (e.g. RDMA-CM). > > Sounds like a great approach to prevent new developers from contributing code. > You have to start somewhere and checkpatch patches are a good entry point for > such developers, discouraging them will only hurt us in the long term. > > Linus had an interesting post on the subject: > https://lkml.org/lkml/2004/12/20/255
