On Thu, Dec 12, 2019 at 10:39:04AM +0200, Leon Romanovsky wrote: > On Thu, Dec 12, 2019 at 01:40:27AM +0000, Saleem, Shiraz wrote: > > > Subject: Re: [PATCH v3 05/20] RDMA/irdma: Add driver framework definitions > > <...> > > > > > > > > + ldev->ops->reg_for_notification(ldev, &events); > > > > + dev_info(rfdev_to_dev(dev), "IRDMA VSI Open Successful"); > > > > > > Lets not do this kind of logging.. > > > > > > > There is some dev_info which should be cleaned up to dev_dbg. > > But logging this info is useful to know that this functions VSI (and associated ibdev) > > is up and reading for RDMA traffic. > > Is info logging to be avoided altogether? > > Will function tracer (ftrace) output be sufficient here? > https://www.kernel.org/doc/html/latest/trace/ftrace.html Yes it should.
