Re: [PATCH rdma-next v1 05/48] RDMA/cm: Request For Communication (REQ) message definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/21/19 10:12 AM, Leon Romanovsky wrote:
...> diff --git a/include/rdma/ib_cm.h b/include/rdma/ib_cm.h
> index b476e0e27ec9..956256b2fc5d 100644
> --- a/include/rdma/ib_cm.h
> +++ b/include/rdma/ib_cm.h
> @@ -65,7 +65,6 @@ enum ib_cm_event_type {
>  };
>  
>  enum ib_cm_data_size {
> -	IB_CM_REQ_PRIVATE_DATA_SIZE	 = 92,
>  	IB_CM_MRA_PRIVATE_DATA_SIZE	 = 222,
>  	IB_CM_REJ_PRIVATE_DATA_SIZE	 = 148,
>  	IB_CM_REP_PRIVATE_DATA_SIZE	 = 196,
> diff --git a/include/rdma/ibta_vol1_c12.h b/include/rdma/ibta_vol1_c12.h
> new file mode 100644
> index 000000000000..885b7b7fdb86
> --- /dev/null
> +++ b/include/rdma/ibta_vol1_c12.h
> @@ -0,0 +1,88 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB */
> +/*
> + * Copyright (c) 2019, Mellanox Technologies inc. All rights reserved.
> + *
> + * This file is IBTA volume 1, chapter 12 declarations:
> + * * CHAPTER 12: C OMMUNICATION MANAGEMENT
> + */
> +#ifndef _IBTA_VOL1_C12_H_
> +#define _IBTA_VOL1_C12_H_
> +
> +#include <rdma/iba.h>
> +
> +#define CM_FIELD_BLOC(field_struct, byte_offset, bits_offset, width)           \
> +	IBA_FIELD_BLOC(field_struct,                                           \
> +		       (byte_offset + sizeof(struct ib_mad_hdr)), bits_offset, \
> +		       width)
> +#define CM_FIELD8_LOC(field_struct, byte_offset, width)                        \
> +	IBA_FIELD8_LOC(field_struct,                                           \
> +		       (byte_offset + sizeof(struct ib_mad_hdr)), width)
> +#define CM_FIELD16_LOC(field_struct, byte_offset, width)                       \
> +	IBA_FIELD16_LOC(field_struct,                                          \
> +			(byte_offset + sizeof(struct ib_mad_hdr)), width)
> +#define CM_FIELD32_LOC(field_struct, byte_offset, width)                       \
> +	IBA_FIELD32_LOC(field_struct,                                          \
> +			(byte_offset + sizeof(struct ib_mad_hdr)), width)
> +#define CM_FIELD_MLOC(field_struct, byte_offset, width)                        \
> +	IBA_FIELD_MLOC(field_struct,                                           \
> +		       (byte_offset + sizeof(struct ib_mad_hdr)), width)
> +
> +/* Table 106 REQ Message Contents */
> +#define CM_REQ_LOCAL_COMM_ID CM_FIELD32_LOC(struct cm_req_msg, 0, 32)
> +#define CM_REQ_SERVICE_ID CM_FIELD64_LOC(struct cm_req_msg, 8, 64)


Is CM_FIELD64_LOC ever defined? I don't see it defined anywhere in the series.

thanks,
-- 
John Hubbard
NVIDIA



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux