On Mon, Dec 2, 2019 at 7:57 PM Steve Wise <larrystevenwise@xxxxxxxxx> wrote: > > Hey Bart, > > Well, as long as every implementation supports proper iCRC and RoCE > standards, I don't see how there could be a problem... > > Let me send my patch out now... > > > On Mon, Dec 2, 2019 at 6:57 PM Bart Van Assche <bvanassche@xxxxxxx> wrote: > > > > On 11/27/19 6:24 AM, Steve Wise wrote: > > > I've recently uncovered a bug in RXE that causes iCRC errors when > > > running between RXE and a correct RoCE implementation. The bug is > > > that RXE is not including pad bytes in its iCRC calculations. So if > > > the application payload is not 4B aligned then you'll hit this bug. > > > You can see this by running ib_write_bw, for example, between mlnx_ib > > > and rxe. > > > > > > works: ib_write_bw -s 32 -n 5 > > > fails: ib_write_bw -s 33 -n 5 > > > > > > I'll post a patch this coming weekend hopefully. > > Hi Steve, > > > > Will that patch support coexistence of softRoCE implementations that use > > different CRC calculation methods? > > > > Thanks, > > > > Bart. In case anyone missed it, I posted my fix for unaligned payloads: https://www.spinics.net/lists/linux-rdma/msg86758.html Steve.
