We rely on a C extension for enums larger than integers. Jason On Thu, Nov 21, 2019 at 04:28:00PM +0000, Edward Srouji wrote: > The C standard specifies that enums are integers (and are guaranteed to > be large enough to hold int). > > These #defines are larger than 32bits (they're 64bits), and even if > they're compiled with the driver, the Cythonization (of Pyverbs) would > treat the enums as integers and the values would be cut. (Cython throws > compilation warnings related to that). > > The PR was updated. > __________________________________________________________________ > > From: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > Sent: Thursday, November 14, 2019 6:50 PM > To: Edward Srouji <edwards@xxxxxxxxxxxx> > Cc: Noa Osherovich <noaos@xxxxxxxxxxxx>; dledford@xxxxxxxxxx > <dledford@xxxxxxxxxx>; Leon Romanovsky <leonro@xxxxxxxxxxxx>; > linux-rdma@xxxxxxxxxxxxxxx <linux-rdma@xxxxxxxxxxxxxxx>; Daria > Velikovsky <daria@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-core 2/4] pyverbs: Introduce ParentDomain > class > > On Thu, Nov 14, 2019 at 04:49:52PM +0000, Edward Srouji wrote: > > They are defined in mlx5dv with #define and not enums. > > I will change to cpdef though. > It is a mistake they are #define > Jason
