On Wed, Nov 20, 2019 at 11:13:31PM -0800, John Hubbard wrote: > A subsequent patch requires access to gup flags, so > pass the flags argument through to the __gup_device_* > functions. Looks fine, but why not fold this into the patch using the flags. Also you can use up your full 73 chars per line in the commit log.