----- Original Message ----- > On Tue, Nov 19, 2019 at 01:58:42PM -0500, Michael S. Tsirkin wrote: > > On Tue, Nov 19, 2019 at 12:46:32PM -0400, Jason Gunthorpe wrote: > > > As always, this is all very hard to tell without actually seeing real > > > accelerated drivers implement this. > > > > > > Your patch series might be a bit premature in this regard. > > > > Actually drivers implementing this have been posted, haven't they? > > See e.g. https://lwn.net/Articles/804379/ > > Is that a real driver? It looks like another example quality > thing. I think the answer is obvious: +static struct pci_driver ifcvf_driver = { + .name = IFCVF_DRIVER_NAME, + .id_table = ifcvf_pci_ids, + .probe = ifcvf_probe, + .remove = ifcvf_remove, +}; > > For instance why do we need any of this if it has '#define > IFCVF_MDEV_LIMIT 1' ? This is just because virtio was done at VF level. Thanks > > Surely for this HW just use vfio over the entire PCI function and be > done with it? > > Jason > >
