On Tue, Nov 19, 2019 at 10:50:06PM +0200, Gal Pressman wrote:
> On 19/11/2019 21:56, Jason Gunthorpe wrote:
> > On Tue, Nov 12, 2019 at 11:17:37AM +0200, Gal Pressman wrote:
> >> diff --git a/include/uapi/rdma/efa-abi.h b/include/uapi/rdma/efa-abi.h
> >> index 9599a2a62be8..442804572118 100644
> >> +++ b/include/uapi/rdma/efa-abi.h
> >> @@ -90,12 +90,21 @@ struct efa_ibv_create_ah_resp {
> >> __u8 reserved_30[2];
> >> };
> >>
> >> +enum {
> >> + EFA_QUERY_DEVICE_CAPS_RDMA_READ = 1 << 0,
> >> +};
> >
> > This doesn't seem needed, caps should only be used if a zero filled
> > reply from an old kernel is not OK.
>
> This isn't a compatibility mask, it's our way to indicate the userspace whether
> the device supports RDMA read. Old kernel/lack of support will return 0, new
> kernel will return 0/1 according to the device support.
Ah, OK
Jason
