On Fri, Nov 15, 2019 at 05:44:57PM +0200, Leon Romanovsky wrote: > From: Danit Goldberg <danitg@xxxxxxxxxxxx> > > While adding new GID, besides comparing GID and type, compare also vlan > id, so vlan GIDs will also be updated in HW GID table although they > have same GID as the default GID. > > Signed-off-by: Danit Goldberg <danitg@xxxxxxxxxxxx> > Reviewed-by: Parav Pandit <parav@xxxxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > --- > drivers/infiniband/hw/mlx4/main.c | 9 ++++++++- > drivers/infiniband/hw/mlx4/mlx4_ib.h | 1 + > 2 files changed, 9 insertions(+), 1 deletion(-) I'm going to apply this because of the bug fix, but this design in mlx4 looks wrong to me? The core gid cache is supposed to manage the gid table completely, and the driver should not be doing searching when the core says to change a table entry. What is going on here? The core code already removes duplicates Parav? Jason
