> -----Original Message----- > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Sunday, November 17, 2019 11:50 PM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx> > Cc: davem@xxxxxxxxxxxxx; Ertman, David M <david.m.ertman@xxxxxxxxx>; > netdev@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > nhorman@xxxxxxxxxx; sassmann@xxxxxxxxxx; jgg@xxxxxxxx; > parav@xxxxxxxxxxxx; Patil, Kiran <kiran.patil@xxxxxxxxx> > Subject: Re: [net-next v2 1/1] virtual-bus: Implementation of Virtual Bus > > On Fri, Nov 15, 2019 at 02:33:55PM -0800, Jeff Kirsher wrote: > > From: Dave Ertman <david.m.ertman@xxxxxxxxx> > > > > This is the initial implementation of the Virtual Bus, virtbus_device > > and virtbus_driver. The virtual bus is a software based bus intended > > to support lightweight devices and drivers and provide matching > > between them and probing of the registered drivers. > > > > The primary purpose of the virual bus is to provide matching services > > and to pass the data pointer contained in the virtbus_device to the > > virtbus_driver during its probe call. This will allow two separate > > kernel objects to match up and start communication. > > > > The bus will support probe/remove shutdown and suspend/resume > > callbacks. > > > > Kconfig and Makefile alterations are included > > > > Signed-off-by: Dave Ertman <david.m.ertman@xxxxxxxxx> > > Signed-off-by: Kiran Patil <kiran.patil@xxxxxxxxx> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> > > --- > > v2: Cleaned up the virtual bus interface based on feedback from Greg KH > > and provided a test driver and test virtual bus device as an example > > of how to implement the virtual bus. > > There is not a real user of this here, many of your exported functions are not > used at all, right? I want to see this in "real use" to actually determine how it > works, and that's the only way you will know if it solves your problem or not. > > thanks, > > greg k-h I totally understand. The ice, i40e, and irdma drivers will be available later this week using the new virtbus. I am implementing some changes suggested by both you and Parav Pandit, otherwise it would already be ready :) -Dave E