On Sun, Nov 17, 2019 at 10:29 AM David Miller <davem@xxxxxxxxxxxxx> wrote: > > From: Tariq Toukan <tariqt@xxxxxxxxxxxx> > Date: Sun, 17 Nov 2019 14:46:50 +0000 > > > > > > > On 11/16/2019 11:10 PM, David Miller wrote: > >> From: Luigi Rizzo <lrizzo@xxxxxxxxxx> > >> Date: Fri, 15 Nov 2019 12:12:25 -0800 > >> > >>> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the > >>> total number of entries in the rx classifier table. Surprisingly, mlx4 > >>> is missing this part (in principle ethtool could still move forward and > >>> try the insert). > >>> > >>> Tested: compiled and run command: > >>> phh13:~# ethtool -N eth1 flow-type udp4 queue 4 > >>> Added rule with ID 255 > >>> > >>> Signed-off-by: Luigi Rizzo <lrizzo@xxxxxxxxxx> > >>> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76 > >> > >> Luigi, _always_ CC: the appropriate maintainer when making changes to the > >> kernel, as per the top-level MAINTAINERS file. > >> > >> Tariq et al., please review. > >> > > > > Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxxxx> > > Applied and queued up for -stable, with Change-Id: removed. Thank you all, apologies for mistakes. cheers luigi