On 14/11/2019 17:59, Jason Gunthorpe wrote:
> On Tue, Nov 12, 2019 at 11:26:08AM +0200, Gal Pressman wrote:
>> We cannot rely on the entry memcpy as we only copy the actual size of
>> the command, the rest of the bytes must be memset to zero.
>>
>> Fixes: 0420e542569b ("RDMA/efa: Implement functions that submit and complete admin commands")
>> Reviewed-by: Daniel Kranzdorf <dkkranzd@xxxxxxxxxx>
>> Reviewed-by: Firas JahJah <firasj@xxxxxxxxxx>
>> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
>> ---
>> drivers/infiniband/hw/efa/efa_com.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> This isn't really -rc material since the device will have to be
> compatible with these old kernels for quite some time.
That's why I pushed it to -rc, this bug fix must be applied to these kernels
(5.2, 5.3) as well through stable.
If we're trying to avoid pushing this change late in the -rc cycle, I'm fine
with this patch going through -next and backported to 5.4 stable as well.
