On Fri, 8 Nov 2019 20:57:08 -0400, Jason Gunthorpe wrote: > On Fri, Nov 08, 2019 at 10:48:31PM +0000, Parav Pandit wrote: > > We should be creating 3 different buses, instead of mdev bus being de-multiplexer of that? > > > > Hence, depending the device flavour specified, create such device on right bus? > > > > For example, > > $ devlink create subdev pci/0000:05:00.0 flavour virtio name foo subdev_id 1 > > $ devlink create subdev pci/0000:05:00.0 flavour mdev <uuid> subdev_id 2 > > $ devlink create subdev pci/0000:05:00.0 flavour mlx5 id 1 subdev_id 3 > > I like the idea of specifying what kind of interface you want at sub > device creation time. It fits the driver model pretty well and doesn't > require abusing the vfio mdev for binding to a netdev driver. Aren't the HW resources spun out in all three cases exactly identical? IMHO creation of sub device should only define which HW resources are provisioned/relegated. Specifying a driver when recreating a device seems a little backwards.