Hi Cornelia, > -----Original Message----- > From: Cornelia Huck <cohuck@xxxxxxxxxx> > Sent: Friday, November 8, 2019 5:11 AM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: alex.williamson@xxxxxxxxxx; davem@xxxxxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Saeed Mahameed > <saeedm@xxxxxxxxxxxx>; kwankhede@xxxxxxxxxx; leon@xxxxxxxxxx; Jiri > Pirko <jiri@xxxxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next 07/19] vfio/mdev: Introduce sha1 based mdev > alias > > On Thu, 7 Nov 2019 10:08:22 -0600 > Parav Pandit <parav@xxxxxxxxxxxx> wrote: > > > Some vendor drivers want an identifier for an mdev device that is > > shorter than the UUID, due to length restrictions in the consumers of > > that identifier. > > > > Add a callback that allows a vendor driver to request an alias of a > > specified length to be generated for an mdev device. If generated, > > that alias is checked for collisions. > > > > It is an optional attribute. > > mdev alias is generated using sha1 from the mdev name. > > > > Reviewed-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > > --- > > drivers/vfio/mdev/mdev_core.c | 123 > ++++++++++++++++++++++++++++++- > > drivers/vfio/mdev/mdev_private.h | 5 +- > > drivers/vfio/mdev/mdev_sysfs.c | 13 ++-- > > include/linux/mdev.h | 4 + > > 4 files changed, 135 insertions(+), 10 deletions(-) > > Is this (or any of the other mdev alias patches) different from what I > reviewed in the past? No. It is not. They are same as what you already reviewed.