On Thu, 7 Nov 2019 10:08:27 -0600, Parav Pandit wrote: > Introduce a new mdev port flavour for mdev devices. > PF. > Prepare such port's phys_port_name using unique mdev alias. > > An example output for eswitch ports with one physical port and > one mdev port: > > $ devlink port show > pci/0000:06:00.0/65535: type eth netdev p0 flavour physical port 0 > pci/0000:06:00.0/32768: type eth netdev p1b0348cf880a flavour mdev alias 1b0348cf880a Surely those devices are anchored in on of the PF (or possibly VFs) that should be exposed here from the start. > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > @@ -6649,6 +6678,9 @@ static int __devlink_port_phys_port_name_get(struct devlink_port *devlink_port, > n = snprintf(name, len, "pf%uvf%u", > attrs->pci_vf.pf, attrs->pci_vf.vf); > break; > + case DEVLINK_PORT_FLAVOUR_MDEV: > + n = snprintf(name, len, "p%s", attrs->mdev.mdev_alias); Didn't you say m$alias in the cover letter? Not p$alias? > + break; > } > > if (n >= len)
