On Mon, Nov 04, 2019 at 12:09:59PM +0100, Benjamin Drung wrote: > Am Montag, den 04.11.2019, 10:37 +0000 schrieb Noa Osherovich: > > diff --git a/pyverbs/cm_enums.pyx b/pyverbs/cm_enums.pyx > > new file mode 120000 > > index 000000000000..bdab2b585a1d > > --- /dev/null > > +++ b/pyverbs/cm_enums.pyx > > @@ -0,0 +1 @@ > > +librdmacm_enums.pxd > > \ No newline at end of file > > diff --git a/pyverbs/cmid.pxd b/pyverbs/cmid.pxd > > new file mode 100755 > > index 000000000000..56bc755daf42 > > --- /dev/null > > +++ b/pyverbs/cmid.pxd > > @@ -0,0 +1,25 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR Linux-OpenIB) > > +# Copyright (c) 2018, Mellanox Technologies. All rights reserved. > > See COPYING file > > + > > +#cython: language_level=3 > > + > > +from pyverbs.base cimport PyverbsObject, PyverbsCM > > +from libc.string cimport memcpy, memset > > +from libc.stdlib cimport free, malloc > > +cimport pyverbs.librdmacm as cm > > + > > + > > +cdef class CMID(PyverbsCM): > > + cdef cm.rdma_cm_id *id > > + cdef object ctx > > + cdef object pd > > + cpdef close(self) > > + > > + > > +cdef class AddrInfo(PyverbsObject): > > + cdef cm.rdma_addrinfo *addr_info > > + cpdef close(self) > > + > > + > > +cdef class ConnParam(PyverbsObject): > > + cdef cm.rdma_conn_param conn_param > > \ No newline at end of file > > Please add newlines to the end of these files. PR was updated. Thanks > > -- > Benjamin Drung > > Debian & Ubuntu Developer > Platform Engineering Compute (Enterprise Cloud) > > 1&1 IONOS SE | Greifswalder Str. 207 | 10405 Berlin | Germany > E-mail: benjamin.drung@xxxxxxxxxxxxxxx | Web: www.ionos.de > > Hauptsitz Montabaur, Amtsgericht Montabaur, HRB 24498 > Vorstand: Dr. Christian Böing, Hüseyin Dogan, Hans-Henning Kettler, > Matthias Steinberg, Achim Weiß > Aufsichtsratsvorsitzender: Markus Kadelke > Member of United Internet >