Re: [PATCH v2] iser: explicitly set shost max_segment_size if non virtual boundary devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




if the rdma device supports sg gaps, we don't need to set a virtual
boundary but we then need to explicitly set the max_segment_size, otherwise
scsi takes BLK_MAX_SEGMENT_SIZE and sets it using dma_set_max_seg_size()
and this affects all the rdma device consumers.

Fix it by setting shost max_segment_size according to the device
capability if SG_GAPS are not supported.

Reported-by: Jason Gunthorpe <jgg@xxxxxxxx>
Suggested-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
---
Changes from v1:
- set max_segment_size only for non virtual boundary devices

  drivers/infiniband/ulp/iser/iscsi_iser.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Sagi, are you respinning this or ??

I can take the change-log message and paste it in the code,
but is that something we want? Usually people look in the
change-log history...

I actually thought it was already in...



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux