On Tue, Oct 29, 2019 at 03:32:46PM +0000, Parav Pandit wrote:
> > > +/**
> > > + * ib_dispatch_event - Dispatch an asynchronous event
> > > + * @event:Event to dispatch
> > > + *
> > > + * Low-level drivers must call ib_dispatch_event() to dispatch the
> > > + * event to all registered event handlers when an asynchronous event
> > > + * occurs.
> > > + */
> > > +void ib_dispatch_event(struct ib_event *event) {
> > > + ib_enqueue_cache_update_event(event);
> > > +}
> > > EXPORT_SYMBOL(ib_dispatch_event);
> >
> > Why not just move this into cache.c?
> >
> Same thought same to me when I had to add one liner call.
> However the issue was device.c has the code for the event registration/unregistration and calling the handlers unrelated to cache.
> So moving ib_dispatch_event() to cache.c looked incorrect to me.
Well, maybe we can move the wq code from the cache.c into here?
It looks just as incorrect to have the one line call
Jason
