On Fri, Oct 18, 2019 at 04:15:34PM +0800, Chuhong Yuan wrote: > Only uverbs_copy_to_struct_or_zero in uverbs_ioctl.c does not have a > check for uverbs_attr_get. > Although its usage in uverbs_response has a check for attr's validity, > UVERBS_HANDLER does not. > Therefore, it is better to add a check like other functions in > uverbs_ioctl.c. > > Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx> > --- > drivers/infiniband/core/uverbs_ioctl.c | 3 +++ > 1 file changed, 3 insertions(+) The call in uverbs_ioctl.c is safe as well, that code path checks that the attribute exists. Still, it make sense that this check should be present, so applied to for-next with a clearer commit message Thanks, Jason