On 10/21/19 2:36 AM, Bernard Metzler wrote: > Why don't we make device_dma_parameters siw_dma_params > just a const in siw_main.c? Having it per siw_device suggests > more flexibility than we actually need and support? Probably > true as well for rxe driver. This is all driver specific. > > Independent of this current patch, probably even true for > siw_device.attrs. We do not have those capabilities siw > device specific, but just siw driver specific. Hi Bernard, The dma_parms pointer in struct device has not been declared const. Assigning a pointer to a const structure to the dma_parms member of struct device would trigger a compiler warning. I think everyone wants to keep the RDMA code free from compiler warnings. Thanks, Bart.