On Wed, Oct 16, 2019 at 01:47:29PM -0400, Don Dutile wrote:
> On 09/30/2019 03:42 AM, Potnuri Bharat Teja wrote:
<...>
> > -
> > -#endif /* CXGB3_ABI_USER_H */
> > diff --git a/include/uapi/rdma/rdma_user_ioctl_cmds.h b/include/uapi/rdma/rdma_user_ioctl_cmds.h
> > index b8bb285f6b2a..b2680051047a 100644
> > --- a/include/uapi/rdma/rdma_user_ioctl_cmds.h
> > +++ b/include/uapi/rdma/rdma_user_ioctl_cmds.h
> > @@ -88,7 +88,6 @@ enum rdma_driver_id {
> > RDMA_DRIVER_UNKNOWN,
> > RDMA_DRIVER_MLX5,
> > RDMA_DRIVER_MLX4,
> > - RDMA_DRIVER_CXGB3,
> > RDMA_DRIVER_CXGB4,
> > RDMA_DRIVER_MTHCA,
> > RDMA_DRIVER_BNXT_RE,
> >
> Isn't there a better way to mark a driver deprecated?
Change in this enum was a mistake.
>
> This kind of removal makes long-term maintenance of such drivers painful in downstream distros, as API changes that are rippled from core through all the drivers, don't update these drivers, and when backporting such API changes to downstream distros, we have to +1 removed drivers.
https://lore.kernel.org/linux-rdma/20191015075419.18185-2-leon@xxxxxxxxxx/T/#u
>
> It's much easier if upstream continues to update the drivers for such across-the-driver-patch-changes.
> heck, add a separate patch that punches out a printk stating DEPRECATED (dropping a patch to backport is easy! :) ).
>
> I told Doug I'd shoot him if he removed another driver from upstream again, that still has to be maintained in RHEL -- don't make me take him *and Jason* out! ;-) ... yeah, you too Jason!
>
>
>
>
>
