On Fri, Oct 11, 2019 at 09:03:33PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > NET_VENDOR_BROADCOM is intended to control a kconfig menu only. > It should not have anything to do with code generation. > As such, it should not select DIMLIB for all drivers under > NET_VENDOR_BROADCOM. Instead each driver that needs DIMLIB should > select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET). > > Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@xxxxxxxxxxxxxx/ > > Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx> > Cc: Tal Gilboa <talgi@xxxxxxxxxxxx> > Cc: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx > Cc: linux-rdma@xxxxxxxxxxxxxxx > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> > Cc: Doug Ledford <dledford@xxxxxxxxxx> > Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx> > Cc: Or Gerlitz <ogerlitz@xxxxxxxxxxxx> > Cc: Sagi Grimberg <sagi@xxxxxxxxxxx> > --- > drivers/net/ethernet/broadcom/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
