On Sat, Sep 28, 2019 at 01:43:51AM +0800, Honggang LI wrote:
> From: Honggang Li <honli@xxxxxxxxxx>
>
> According to SRP specifications 'srp-r16a' and 'srp2r06',
> IOControllerProfile attributes for SRP target port include
> the maximum initiator to target IU size.
>
> SRP connection daemons, such as srp_daemon, can get the value
> from subnet manager. The SRP connection daemon can pass this
> value to kernel.
>
> This patch add parse function for it.
>
> Upstream commit [1] enables the kernel parameter, 'use_imm_data',
> by default. [1] also use (8 * 1024) as the default value for
> kernel parameter 'max_imm_data'. With those default values, the
> maximum initiator to target IU size will be 8260.
>
> In case the SRPT modules, which include the in-tree 'ib_srpt.ko'
> module, do not support SRP-2 'immediate data' feature, the default
> maximum initiator to target IU size is significantly smaller than
> 8260. For 'ib_srpt.ko' module, which built from source before
> [2], the default maximum initiator to target IU is 2116.
>
> [1] introduces a regression issue for old srp target with default
> kernel parameters, as the connection will be reject because of
> too large maximum initiator to target IU size.
>
> [1] commit 882981f4a411 ("RDMA/srp: Add support for immediate data")
> [2] commit 5dabcd0456d7 ("RDMA/srpt: Add support for immediate data")
>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
> Signed-off-by: Honggang Li <honli@xxxxxxxxxx>
> ---
> Documentation/ABI/stable/sysfs-driver-ib_srp | 2 ++
> drivers/infiniband/ulp/srp/ib_srp.c | 10 ++++++++++
> drivers/infiniband/ulp/srp/ib_srp.h | 1 +
> 3 files changed, 13 insertions(+)
Applied to for-next, thanks
Jason
