From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Changelog:
v2:
* Since umems can disappear during rereg flow and the fact that we
are not locking its during our counter usage (uverbs prevents this
by holding the uobject write lock), expose possible race bugs. Move
the counters into mlx5_ib_mr to avoid racing bugs (related patches
- #1, #3 & #4).
* Fix page invalidation counting (Patch #1).
* Make the code more elegant by defining fill_function type and use it
within res_common_{dumpit, doit} (Patch #2).
* Put an ODP implicit indicator within mlx5 reg MR operation,
indicating when a given MR is ODP implicit registered and use
its indication when dumping ODP type.
* Since the counters has been moved to mlx5_ib_mr, the ODP stats are now
filled with internal to mlx5 driver function. Remove the fill_odp_stats
device operation from the reason mentioned above.
v1: https://lore.kernel.org/linux-rdma/20190830081612.2611-1-leon@xxxxxxxxxx
* Dropped umem patch, because it doesn't follow our IB model, where
UMEM is driver object and ib_core object (Jason).
* Removed the ODP type indicator from ib_umem_odp not needed after
commit fd7dbf035edc ("RDMA/odp: Make it clearer when a umem is an implicit ODP umem")
* Since umems are not part of core MR (from the reason mentioned
above) there is no way to access the odp type as was previously done via nldev
(old patch #3). Instead, patch #4 is adding mlx5 implementation for fill_res_entry
and dumping ODP type as part of the driver table entry, as its driver details.
* Counter types are now atomic64_t instead of u64.
v0: https://lore.kernel.org/linux-rdma/20190807103403.8102-1-leon@xxxxxxxxxx
-----------------------------------------------------------------------------
Hi,
This series from Erez refactors exposes ODP type information (explicit,
implicit) and statistics through netlink interface.
Thanks
Erez Alfasi (4):
IB/mlx5: Introduce ODP diagnostic counters
RDMA/nldev: Allow different fill function per resource
RDMA/mlx5: Return ODP type per MR
RDMA/nldev: Provide MR statistics
drivers/infiniband/core/device.c | 1 +
drivers/infiniband/core/nldev.c | 98 ++++++++++++++++++++-------
drivers/infiniband/hw/mlx5/Makefile | 2 +-
drivers/infiniband/hw/mlx5/main.c | 3 +
drivers/infiniband/hw/mlx5/mlx5_ib.h | 9 +++
drivers/infiniband/hw/mlx5/odp.c | 20 ++++++
drivers/infiniband/hw/mlx5/restrack.c | 92 +++++++++++++++++++++++++
include/rdma/ib_verbs.h | 13 ++++
include/rdma/restrack.h | 6 ++
9 files changed, 218 insertions(+), 26 deletions(-)
create mode 100644 drivers/infiniband/hw/mlx5/restrack.c
--
2.20.1
