On Wed, Oct 02, 2019 at 05:45:04PM +0200, Jinpu Wang wrote:
> On Wed, Oct 2, 2019 at 5:42 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> >
> > On Wed, Oct 02, 2019 at 05:15:10PM +0200, Jinpu Wang wrote:
> > > On Tue, Sep 24, 2019 at 1:56 AM Bart Van Assche <bvanassche@xxxxxxx> wrote:
> > > >
> > > > On 6/20/19 8:03 AM, Jack Wang wrote:
> > > > > +ssize_t ibtrs_srv_stats_rdma_to_str(struct ibtrs_srv_stats *stats,
> > > > > + char *page, size_t len)
> > > > > +{
> > > > > + struct ibtrs_srv_stats_rdma_stats *r = &stats->rdma_stats;
> > > > > + struct ibtrs_srv_sess *sess;
> > > > > +
> > > > > + sess = container_of(stats, typeof(*sess), stats);
> > > > > +
> > > > > + return scnprintf(page, len, "%lld %lld %lld %lld %u\n",
> > > > > + (s64)atomic64_read(&r->dir[READ].cnt),
> > > > > + (s64)atomic64_read(&r->dir[READ].size_total),
> > > > > + (s64)atomic64_read(&r->dir[WRITE].cnt),
> > > > > + (s64)atomic64_read(&r->dir[WRITE].size_total),
> > > > > + atomic_read(&sess->ids_inflight));
> > > > > +}
> > > >
> > > > Does this follow the sysfs one-value-per-file rule? See also
> > > > Documentation/filesystems/sysfs.txt.
> > > >
> > > > Thanks,
> > > >
> > > > Bart.
> > > It looks overkill to create one file for each value to me, and there
> > > are enough stats in sysfs contain multiple values.
> >
> > Not for statistics.
> 2 examples:
> cat /sys/block/nvme0n1/inflight
> 0 0
> cat /sys/block/nvme0n1/stat
> 1267566 53 85396638 927624 4790532 3076340 198306930
> 19413605 0 2459788 17013620 74392 0 397606816
> 6864
OMG, I feel sorry for users who now should go and read code to see what
column 3 in second row means.
We respect our users, please don't do like they did.
Thanks
>
> Thanks
