On 9/18/19 8:50 PM, Honggang LI wrote:
From: Honggang Li <honli@xxxxxxxxxx>
The default maximum immediate size is too big for old srp clients,
which without immediate data support.
^^^^^^^
do not?
According to the SRP and SRP-2 specifications, the IOControllerProfile
attributes for SRP target ports contains the maximum initiator to target
iu length.
The maximum initiator to target iu length can be get from the subnet
^^^
retrieved? obtained?
manager, such as opensm and opafm. We should calculate the
^^^^^^^
Are you sure that information comes from the subnet manager?
Isn't the LID passed to get_ioc_prof() in the srp_daemon the LID of the
SRP target?
Anyway, since the code changes look fine to me, feel free to add:
Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
