On 9/18/19, 4:08 PM, "Adit Ranadive" <aditr@xxxxxxxxxx> wrote: >An extra kfree cleanup was missed since these are now deallocated >by core. > >Cc: <stable@xxxxxxxxxxxxxxx> >Fixes: 68e326dea1db ("RDMA: Handle SRQ allocations by IB/core") >Signed-off-by: Adit Ranadive <aditr@xxxxxxxxxx> >--- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c >index 6cac0c88cf39..36cdfbdbd325 100644 >--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c >+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c >@@ -230,8 +230,6 @@ static void pvrdma_free_srq(struct pvrdma_dev *dev, struct pvrdma_srq *srq) > > pvrdma_page_dir_cleanup(dev, &srq->pdir); > >- kfree(srq); >- > atomic_dec(&dev->num_srqs); > } Thanks for the fix, looks good to me. Reviewed-by: Vishnu Dasa <vdasa@xxxxxxxxxx> -- vishnu