On Tue, Sep 17, 2019 at 5:42 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > On Mon, Sep 16, 2019 at 06:45:17AM -0700, Bart Van Assche wrote: > > On 9/15/19 10:27 PM, Leon Romanovsky wrote: > > > On Sun, Sep 15, 2019 at 04:30:04PM +0200, Jinpu Wang wrote: > > > > On Sat, Sep 14, 2019 at 12:10 AM Bart Van Assche <bvanassche@xxxxxxx> wrote: > > > > > > +/* TODO: should be configurable */ > > > > > > +#define IBTRS_PORT 1234 > > > > > > > > > > How about converting this macro into a kernel module parameter? > > > > Sounds good, will do. > > > > > > Don't rush to do it and defer it to be the last change before merging, > > > this is controversial request which not everyone will like here. > > > > Hi Leon, > > > > If you do not agree with changing this macro into a kernel module parameter > > please suggest an alternative. > > I didn't review code so my answer can be not fully accurate, but opening > some port to use this IB* seems strange from my non-sysadmin POV. > What about using RDMA-CM, like NVMe? Hi Leon, We are using rdma-cm, the port number here is same like addr_trsvcid in NVMeoF, it controls which port rdma_listen is listening on. Currently, it's hardcoded, I've adapted the code to have a kernel module parameter port_nr in ibnbd_server, so it's possible to change it if the sysadmin wants. Thanks, -- Jack Wang Linux Kernel Developer Platform Engineering Compute (IONOS Cloud)
