> -----Original Message----- > From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > Sent: Wednesday, September 11, 2019 3:42 PM > To: liweihang <liweihang@xxxxxxxxxxxxx> > Cc: dledford@xxxxxxxxxx; jgg@xxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > Linuxarm <linuxarm@xxxxxxxxxx> > Subject: Re: [PATCH rdma-core 5/5] libhns: Support configuring loopback > mode by user > > On Tue, Sep 10, 2019 at 08:20:52PM +0800, Weihang Li wrote: > > User can configure whether hardware working on loopback mode or not by > > export an environment variable "HNS_ROCE_LOOPBACK". > > It is definitely wrong interface to configure behaviour of application. > Environment variables make sense if you need to change library behaviour. > > Thanks Hi Leon, Could you please give some advices on how to get configurations from users? Thanks, Weihang