> -----Original Message----- > From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > Sent: Wednesday, September 11, 2019 3:36 PM > To: liweihang <liweihang@xxxxxxxxxxxxx> > Cc: dledford@xxxxxxxxxx; jgg@xxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > Linuxarm <linuxarm@xxxxxxxxxx> > Subject: Re: [PATCH rdma-core 3/5] libhns: Refactor for post send > > On Tue, Sep 10, 2019 at 08:20:50PM +0800, Weihang Li wrote: > > From: Yixian Liu <liuyixian@xxxxxxxxxx> > > > > This patch refactors the interface of hns_roce_u_v2_post_send, which > > is now very complicated. We reduce the complexity with following points: > > 1. Separate RC server into a function. > > 2. Simplify and separate the process of sge. > > 3. Keep the logic and consistence of all operations. > > > > Signed-off-by: Yixian Liu <liuyixian@xxxxxxxxxx> > > Signed-off-by: Weihang Li <liweihang@xxxxxxxxxxxxx> > > --- > > providers/hns/hns_roce_u.h | 7 + > > providers/hns/hns_roce_u_hw_v2.c | 427 > > ++++++++++++++++----------------------- > > 2 files changed, 186 insertions(+), 248 deletions(-) > > > > No printf() calls in the providers code, please. > > Thanks OK, will modify them, thank you.