Re: Re: [PATCH] RDMA/siw: Fix page address mapping in TX path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----"Leon Romanovsky" <leon@xxxxxxxxxx> wrote: -----

>To: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx>
>From: "Leon Romanovsky" <leon@xxxxxxxxxx>
>Date: 09/09/2019 12:03PM
>Cc: linux-rdma@xxxxxxxxxxxxxxx, krishna2@xxxxxxxxxxx,
>dledford@xxxxxxxxxx
>Subject: [EXTERNAL] Re: [PATCH] RDMA/siw: Fix page address mapping in
>TX path
>
>On Fri, Sep 06, 2019 at 04:21:49PM +0200, Bernard Metzler wrote:
>> Use the correct kmap()/kunmap() flow to determine page
>> address used for CRC computation. Using page_address()
>> is wrong, since page might be in highmem.
>>
>> Reported-by: Krishnamraju Eraparaju <krishna2@xxxxxxxxxxx>
>> Fixes: b9be6f18cf9e ("rdma/siw: transmit path")
>> Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
>> ---
>>  drivers/infiniband/sw/siw/siw_qp_tx.c | 11 ++++++-----
>>  1 file changed, 6 insertions(+), 5 deletions(-)
>
>Bernard,
>
>You need to write version and target in your title [PATCH v100
>rdma-next] ...
>And changelog.

Thanks Leon,
will do. I'd like to have that accepted asap,
since it is a code fix. The driver would crash if it
tries CRC on data in highmem. So let me mark it
'for-rc'. Or would 'rdma-rc' be better? Just see
these two variants on the list...


Thanks!
Bernard.
>
>Thanks
>
>




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux