Re: [PATCH] rdma/siw: fix NOMMU build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 7, 2019 at 9:34 AM Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote:
> > @@ -374,7 +374,7 @@ struct siw_umem *siw_umem_get(u64 start, u64 len, bool writable)
> >       unsigned int foll_flags = FOLL_WRITE;
> >       int num_pages, num_chunks, i, rv = 0;
> >
> > -     if (!can_do_mlock())
> > +     if (!IS_ENABLED(CONFIG_MMU) || !can_do_mlock())
> >               return ERR_PTR(-EPERM);
>
> I feel like !CONFIG_MMU should provide a dummy inline stub for can_do_mlock
> instead?

Fair enough. I've added that to my test tree in place of my first patch
and will send it after some more build testing.

     Arnd



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux