> From: Bernard Metzler <BMT@xxxxxxxxxxxxxx>
> Sent: Tuesday, September 3, 2019 5:16 PM
>
> External Email
>
> ----------------------------------------------------------------------
> -----"Michal Kalderon" <michal.kalderon@xxxxxxxxxxx> wrote: -----
>
> >To: <mkalderon@xxxxxxxxxxx>, <aelior@xxxxxxxxxxx>, <jgg@xxxxxxxx>,
> ><dledford@xxxxxxxxxx>, <bmt@xxxxxxxxxxxxxx>,
> <galpress@xxxxxxxxxx>,
> ><sleybo@xxxxxxxxxx>, <leon@xxxxxxxxxx>
> >From: "Michal Kalderon" <michal.kalderon@xxxxxxxxxxx>
> >Date: 09/02/2019 06:25PM
> >Cc: <linux-rdma@xxxxxxxxxxxxxxx>, "Michal Kalderon"
> ><michal.kalderon@xxxxxxxxxxx>, "Ariel Elior"
> ><ariel.elior@xxxxxxxxxxx>
> >Subject: [EXTERNAL] [PATCH v9 rdma-next 4/7] RDMA/siw: Use the
> common
> >mmap_xa helpers
> >
> >Remove the functions related to managing the mmap_xa database.
> >This code is now common in ib_core. Use the common API's instead.
> >
> >Signed-off-by: Ariel Elior <ariel.elior@xxxxxxxxxxx>
> >Signed-off-by: Michal Kalderon <michal.kalderon@xxxxxxxxxxx>
> >---
> > drivers/infiniband/sw/siw/siw.h | 20 +++-
> > drivers/infiniband/sw/siw/siw_main.c | 1 +
> > drivers/infiniband/sw/siw/siw_verbs.c | 216
> >++++++++++++++++++----------------
> > drivers/infiniband/sw/siw/siw_verbs.h | 1 +
> > 4 files changed, 131 insertions(+), 107 deletions(-)
> >
> >diff --git a/drivers/infiniband/sw/siw/siw.h
> >b/drivers/infiniband/sw/siw/siw.h
> >index 77b1aabf6ff3..c20b4ee1cb4b 100644
> >--- a/drivers/infiniband/sw/siw/siw.h
> >+++ b/drivers/infiniband/sw/siw/siw.h
> >@@ -220,7 +220,7 @@ struct siw_cq {
> > u32 cq_get;
> > u32 num_cqe;
> > bool kernel_verbs;
> >- u32 xa_cq_index; /* mmap information for CQE array */
> >+ u64 cq_key; /* mmap information for CQE array */
> > u32 id; /* For debugging only */
> > };
> >
> >
>
> Michal, many thanks for taking care of
> it for the siw driver! Maybe we can
> remove the key sanity checks before calling
> rdma_user_mmap_entry_remove(). That's my only point with the current
> patch - nothing functional, and probably just OK as is.
As I'm already sending another series I will remove the double sanity checks.
Thanks.
>
> I tested it with both user clients (rping) and kernel clients (nvmf target) and it
> worked OK.
>
Great thanks.
>
> Reviewed-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
> Tested-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
