Re: [PATCH] iwcm: don't hold the irq disabled lock on iw_rem_ref

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 03, 2019 at 07:33:08PM +0000, Mark Bloch wrote:
> 
> 
> On 9/3/19 12:22 PM, Sagi Grimberg wrote:
> > This may be the final put on a qp and result in freeing
> > resourcesand should not be done with interrupts disabled.
> > 
> > Produce the following warning:
> 
> Shouldn't you first do cm_id_priv->qp = NULL and only then
> unlock and destroy the qp?
> 
> Mark
> >  	}
> >  	spin_unlock_irqrestore(&cm_id_priv->lock, flags);

Would avoid the sketchy unlock too.. But does it work?

Jason
 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux