On 8/22/2019 7:52 PM, Jason Gunthorpe wrote: > On Thu, Aug 22, 2019 at 01:18:24PM -0300, Leon Romanovsky wrote: >> On Tue, Aug 20, 2019 at 01:00:47PM +0000, Noa Osherovich wrote: >>> On 8/19/2019 4:50 PM, Jason Gunthorpe wrote: >>> >>>> I'd prefer run_tests to be in the tests directory.. >>>> >>>> Jason >>> PR was updated >> 1. >> IMHO, run_tests.py should be placed inside tests directory too and not >> only installed into tests/. > Yes, this is what I ment. The file should be in tests/ and it should > be built into build/bin, and installed into the examples >> 2. >> Execution of run_tests.py produces a lot of untracked filed >> ➜ rdma-core git:(noaos-pr-tests) ✗ git st >> On branch noaos-pr-tests >> Untracked files: >> (use "git add <file>..." to include in what will be committed) >> >> pyverbs/__init__.pyc >> pyverbs/pyverbs_error.pyc >> tests/__init__.pyc >> tests/base.pyc >> tests/test_addr.pyc >> tests/test_cq.pyc >> tests/test_device.pyc >> tests/test_mr.pyc >> tests/test_odp.pyc >> tests/test_pd.pyc >> tests/test_qp.pyc > *.pyc will have to be added to the .gitignore >> 3. run_tests.py lacks of python3 shebang > Originally it was not installed, so this was fine, as the build/bin > script does all the required setup, however now that it is to be > installed it should have the #! - and it should also work without any > trouble from it's example location. > > Jason PR was updated. Thanks, Noa
