On Tue, 2019-08-27 at 11:12 +0800, Mao Wenan wrote: > When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors The issue happens when PCI_HYPERV_INTERFACE is a module and mlx5_core is built-in. > are found: > drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function > `mlx5e_nic_enable': > en_main.c:(.text+0xb649): undefined reference to > `mlx5e_hv_vhca_stats_create' > drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function > `mlx5e_nic_disable': > en_main.c:(.text+0xb8c4): undefined reference to > `mlx5e_hv_vhca_stats_destroy' > > This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by > 'commit 348dd93e40c1 > ("PCI: hv: Add a Hyper-V PCI interface driver for software > backchannel interface"), > Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE. > the imply should be in MLX5_CORE not MLX5_CORE_EN since the implementation also involves MLX5_CORE. I will prepare a patch with these fixups. Thanks, Saeed.