-----"Leon Romanovsky" <leon@xxxxxxxxxx> wrote: ----- >To: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx> >From: "Leon Romanovsky" <leon@xxxxxxxxxx> >Date: 08/28/2019 12:47PM >Cc: linux-rdma@xxxxxxxxxxxxxxx, bvanassche@xxxxxxx, jgg@xxxxxxxx, >dledford@xxxxxxxxxx >Subject: [EXTERNAL] Re: [PATCH v3] RDMA/siw: Fix IPv6 addr_list >locking > >On Wed, Aug 28, 2019 at 11:38:41AM +0200, Bernard Metzler wrote: >> Walking the address list of an inet6_dev requires >> appropriate locking. Since the called function >> siw_listen_address() may sleep, we have to use >> rtnl_lock() instead of read_lock_bh(). >> >> Also introduces sanity checks if we got a device >> from in_dev_get() or in6_dev_get(). >> >> Changes from v2: >> - Use plain version of list_for_each_entry >> in exchange of list_for_each_entry_rcu. >> >> Changes from v1: >> - Remove rcu_read_lock()/_unlock(). >> - Add check for IFA_F_TENTATIVE and >> IFA_F_DEPRECATED flags. > >You need to add changelogs after "---" line, they will be trimmed >automatically while applying to git. > Ah OK, next try... Thanks for everybody's patience. Bernard.
