-----"Leon Romanovsky" <leon@xxxxxxxxxx> wrote: ----- >To: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx> >From: "Leon Romanovsky" <leon@xxxxxxxxxx> >Date: 08/28/2019 07:03AM >Cc: linux-rdma@xxxxxxxxxxxxxxx, bvanassche@xxxxxxx, jgg@xxxxxxxx, >dledford@xxxxxxxxxx >Subject: [EXTERNAL] Re: [PATCH v3] RDMA/siw: Fix IPv6 addr_list >locking > >On Wed, Aug 28, 2019 at 12:07:20AM +0200, Bernard Metzler wrote: >> Walking the address list of an inet6_dev requires >> appropriate locking. Since the called function >> siw_listen_address() may sleep, we have to use >> rtnl_lock() instead of read_lock_bh(). >> >> Also introduces: >> - sanity checks if we got a device from >> in_dev_get() or in6_dev_get(). >> - skipping IPv6 addresses flagged IFA_F_TENTATIVE >> or IFA_F_DEPRECATED >> >> Reported-by: Bart Van Assche <bvanassche@xxxxxxx> >> Fixes: 6c52fdc244b5 ("rdma/siw: connection management") >> Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx> >> --- > >Bernand, > >Can you please post changelog along your patches? > Hi Leon, Thanks, yes. Let me further try getting it alright ;) I'll re-post v3. Sorry! Bernard.