On 2019/8/25 7:58, David Miller wrote:
From: Zhu Yanjun <yanjun.zhu@xxxxxxxxxx> Date: Fri, 23 Aug 2019 21:04:16 -0400diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h index fd6b5f6..cba368e 100644 --- a/include/uapi/linux/rds.h +++ b/include/uapi/linux/rds.h @@ -250,6 +250,7 @@ struct rds_info_rdma_connection { __u32 rdma_mr_max; __u32 rdma_mr_size; __u8 tos; + __u8 sl; __u32 cache_allocs; };I'm applying this, but I am once again severely disappointed in how RDS development is being handled. >From the Fixes: commit: Since rds.h in rds-tools is not related with the kernel rds.h, the change in kernel rds.h does not affect rds-tools. This is the height of arrogance and shows a lack of understanding of what user ABI requirements are all about. It is possible for other userland components to be built by other people, outside of your controlled eco-system and tools, that use these interfaces. And you cannot control that. Therefore you cannot make arbitrary changes to UABI data strucures just because the tool you use and maintain is not effected by it. Please stop making these incredibly incompatible user interface changes in the RDS stack. I am, from this point forward, going to be extra strict on RDS stack changes especially in this area.
OK. It is up to you to decide to merge this commit or not. Zhu Yanjun
