On Thu, Aug 22, 2019 at 09:38:07PM +0300, Leon Romanovsky wrote: > On Thu, Aug 22, 2019 at 07:58:56PM +0200, Marcin Mielniczuk wrote: > > On 22.08.2019 19:21, Leon Romanovsky wrote: > > > On Thu, Aug 22, 2019 at 07:05:12PM +0200, Marcin Mielniczuk wrote: > > >> Thanks a lot, this did the trick. I think this is worth documenting > > >> somewhere that this step is needed. > > >> I'll make a PR, would README.md in the rdma-core repo be a good place? > > > I'm not so sure, but it is better to have in some place instead of not having at all. > > I think it's the first place one would look for some information. I'll > > make a PR today or tomorrow. > > >> Does <NAME> have any significance? I did: > > >> > > >> sudo rdma link add siw0 type siw netdev enpXsYYfZ > > >> > > >> but the resulting device is called iwpXsYYfZ. I couldn't find a trace of > > >> `siw0` anywhere. > > > I would say that it is a bug in kernel part of SIW, because kernel rename > > > (the thing which change your siw0 to be iw* name) is looking for absence > > > of mentioning PCI inside of /sys/class/infiniband/siw0/* > > > https://github.com/linux-rdma/rdma-core/blob/master/kernel-boot/rdma_rename.c#L378 > > I don't have /sys/class/infiniband/siw0 on my system, only > > /sys/class/infiniband/iwpXsYYfZ. > > iwp probably comes from iWARP. > > Your iwpXsYYfZ was siw0 before rdma_rename was executed. > > I can't test the patch now, but hope that this change below will fix your problem. I think we should directly blacklist rxe and siw from renaming. They can only be created with a user-given name so they should never ever be renamed. netlink now returns the driver_id and we can use that to trigger it. Jason
