On Wed, Aug 21, 2019 at 05:21:15PM +0300, Yuval Shaia wrote: > /* > * Describe the input structs for write(). Some write methods have an input > * only struct, most have an input and output. If the struct has an output then > @@ -3999,6 +4089,11 @@ const struct uapi_definition uverbs_def_write_intf[] = { > UAPI_DEF_WRITE_IO(struct ib_uverbs_query_port, > struct ib_uverbs_query_port_resp), > UAPI_DEF_METHOD_NEEDS_FN(query_port)), > + DECLARE_UVERBS_WRITE( > + IB_USER_VERBS_CMD_IMPORT_FR_FD, > + ib_uverbs_import_fr_fd, > + UAPI_DEF_WRITE_IO(struct ib_uverbs_import_fr_fd, > + union ib_uverbs_import_fr_fd_resp)), I'm sure I said this already, no new write() verbs. New things must use ioctl. Since this looks 100% driver specific it should be a set of driver specific ioctls. Jason