On Thu, 2019-08-08 at 11:39 +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> NULL-ing notifier_call is performed under protection
> of mlx5_ib_multiport_mutex lock. Such protection is
> not easily spotted and better to be guarded by lockdep
> annotation.
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> Based on -rc commit: 23eaf3b5c1a7 ("RDMA/mlx5: Release locks during
> notifier unregister")
> ---
> drivers/infiniband/hw/mlx5/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c
> b/drivers/infiniband/hw/mlx5/main.c
> index 7933534be931..63969484421c 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -5835,6 +5835,8 @@ static void mlx5_ib_unbind_slave_port(struct
> mlx5_ib_dev *ibdev,
> int err;
> int i;
>
> + lockdep_assert_held(&mlx5_ib_multiport_mutex);
> +
> mlx5_ib_cleanup_cong_debugfs(ibdev, port_num);
>
> spin_lock(&port->mp.mpi_lock);
> --
> 2.20.1
>
Hi Leon,
This patch needed to catch both the unbind and the bind/init routine as
they both require the multiport mutex be held. Can you respin please?
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part
