On 07/08/2019 14:44, Jason Gunthorpe wrote:
> On Wed, Aug 07, 2019 at 02:23:03PM +0300, Gal Pressman wrote:
>> On 07/08/2019 13:33, Leon Romanovsky wrote:
>>> +static inline void ib_umem_odp_set_type(struct ib_umem_odp *umem_odp,
>>> + unsigned long start, size_t end)
>>
>> Consider renaming 'end' to 'size'?
>>
>>> +{
>>> + if (!start && !end)
>>
>> According to the man pages, To create an implicit ODP MR, IBV_ACCESS_ON_DEMAND
>> should be set, addr should be 0 and length should be SIZE_MAX.
>> Why check end against zero?
>
> Because that isn't how it works at the umem level. The driver detects
> tha above and triggers a special umem creation flow that has a 0
> length umem.
I see, thanks!
