After discussing with Leon, libibumad and probably infiniband-diags should be redesigned to follow new rdma-core policy of using netlink API. This redesign will be added to the POR and will be provided on top of provided patches. So in short-term, the patches will be accepted after fixing comments #1-#2. In long-term, libibumad support for netlink API will be provided. -----Original Message----- From: Leon Romanovsky <leon@xxxxxxxxxx> Sent: Wednesday, August 7, 2019 10:45 AM To: Vladimir Koushnir <vladimirk@xxxxxxxxxxxx> Cc: Haim Boozaglo <haimbo@xxxxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx Subject: Re: [PATCH 1/3] libibumad: Support arbitrary number of IB devices On Wed, Aug 07, 2019 at 07:26:35AM +0000, Vladimir Koushnir wrote: > Leon, > > For comment #3: > We are not planning to change implementation of libibumad. > The patches were developed with existing libibumad code and extending > existing capability to provide list of devices on the node beyond 32 > devocs You are proposing patches for inclusion in upstream rdma-core and our request is to use the same functionality as already available in rdma-core. We don't ask you to rewrite existing libibumad code, but don't submit wrong code. > > For comment #4: > Hot-plug is out-of-scope of the libibumad as no persistent data is maintained by libibumad. Fair enough. Thanks > > -----Original Message----- > From: Leon Romanovsky <leon@xxxxxxxxxx> > Sent: Tuesday, August 6, 2019 6:52 PM > To: Haim Boozaglo <haimbo@xxxxxxxxxxxx> > Cc: linux-rdma@xxxxxxxxxxxxxxx; Vladimir Koushnir > <vladimirk@xxxxxxxxxxxx> > Subject: Re: [PATCH 1/3] libibumad: Support arbitrary number of IB > devices > > On Tue, Aug 06, 2019 at 02:38:52PM +0000, Haim Boozaglo wrote: > > From: Vladimir Koushnir <vladimirk@xxxxxxxxxxxx> > > > > Added new function returning a list of available InfiniBand device names. > > The returned list is not limited to 32 devices. > > > > Signed-off-by: Vladimir Koushnir <vladimirk@xxxxxxxxxxxx> > > Signed-off-by: Haim Boozaglo <haimbo@xxxxxxxxxxxx> > > --- > > libibumad/CMakeLists.txt | 2 +- > > libibumad/libibumad.map | 6 +++++ > > libibumad/man/umad_free_ca_namelist.3 | 28 ++++++++++++++++++++++++ > > libibumad/man/umad_get_ca_namelist.3 | 34 +++++++++++++++++++++++++++++ > > libibumad/umad.c | 41 +++++++++++++++++++++++++++++++++++ > > libibumad/umad.h | 2 ++ > > 6 files changed, 112 insertions(+), 1 deletion(-) create mode > > 100644 > > libibumad/man/umad_free_ca_namelist.3 > > create mode 100644 libibumad/man/umad_get_ca_namelist.3 > > 1. Please use cover letter for patch series. > 2. There is a need to update debian package too. > 3. Need to use the same discovery mechanism as used in libibverbs - netlink based. > 4. Does it work with hot-plug where device name can change? > > Thanks
