On Fri, Aug 02, 2019 at 08:10:35PM +0800, Chuhong Yuan wrote: > Reference counters are preferred to use refcount_t instead of > atomic_t. > This is because the implementation of refcount_t can prevent > overflows and detect possible use-after-free. > > First convert the refcount field to refcount_t in mlx5/driver.h. > Then convert the uses to refcount_() APIs. You can't do it, because you need to ensure that driver compiles and works between patches. By converting driver.h alone to refcount_t, you simply broke mlx5 driver. NAK, to be clear. And please don't sent series of patches as standalone patches. Thanks,