On Thu, Aug 01, 2019 at 12:40:43PM -0400, Doug Ledford wrote: > > It does have a lock though, the caller holds it, hence the request for > > the lockdep. > > You're right, although I think the lockdep annotation can be a separate > patch as it's neeeded on more than just the function this patch touches. Why? This relies on that lock, so it should have the lockdep_assert_held assert. If there are more functions with implicit locking theyt they can be fixed separately... Jason
