On Tue, 2019-07-30 at 18:22 +0300, Leon Romanovsky wrote:
> On Tue, Jul 30, 2019 at 04:37:20PM +0300, Gal Pressman wrote:
> > The check for QP type different than XRC has wrongly excluded driver
> > QP
> > types from the resource tracker.
> > As a result, "rdma resource show" user command would not show opened
> > driver QPs which does not reflect the real state of the system.
> >
> > Check QP type explicitly instead of improperly assuming enum
> > values/ordering.
> >
> > Fixes: 78a0cd648a80 ("RDMA/core: Add resource tracking for create
> > and destroy QPs")
> > Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
> > ---
> > v2:
> > * Improve commit message
>
> Please finish review of v0 and give enough time for reviewers to see
> patch and post their notes before resending.
Gal, Leon was right in his comments to the v1 of this patch in terms of
the original code not being broken prior to the existence of driver qp
types. This fix isn't needed until after the EFA driver is merged, and
the Fixes: tag is used in order for scripts to know if they need to take
a patch because they've already taken the patch prior. So the Fixes tag
needs to be the EFA driver, not the original resource tracking commit,
as there is no issue unless the EFA driver is placed on top of the
original resource tracking commit. Please resubmit with a proper commit
message and fixes tag.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part
