On Sun, Jul 28, 2019 at 12:30:51PM +0300, Kamal Heib wrote: > > Maybe put this in ib_core_uverbs.c ? > > > > Kamal, you've been tackling various cleanups, maybe making ib_uverbs > > unloadable again is something you'd be keen on? > > > > Yes, Could you please give some background on that? Most of it is my fault from being too careless, but the general notion is that all of these $ grep EXPORT_SYMBOL uverbs_main.c uverbs_cmd.c uverbs_marshall.c rdma_core.c uverbs_std_types*.c uverbs_uapi.c uverbs_main.c:EXPORT_SYMBOL(ib_uverbs_get_ucontext_file); uverbs_main.c:EXPORT_SYMBOL(rdma_user_mmap_io); uverbs_cmd.c:EXPORT_SYMBOL(flow_resources_alloc); uverbs_cmd.c:EXPORT_SYMBOL(ib_uverbs_flow_resources_free); uverbs_cmd.c:EXPORT_SYMBOL(flow_resources_add); uverbs_marshall.c:EXPORT_SYMBOL(ib_copy_ah_attr_to_user); uverbs_marshall.c:EXPORT_SYMBOL(ib_copy_qp_attr_to_user); uverbs_marshall.c:EXPORT_SYMBOL(ib_copy_path_rec_to_user); uverbs_marshall.c:EXPORT_SYMBOL(ib_copy_path_rec_from_user); rdma_core.c:EXPORT_SYMBOL(uverbs_idr_class); rdma_core.c:EXPORT_SYMBOL(uverbs_close_fd); rdma_core.c:EXPORT_SYMBOL(uverbs_fd_class); uverbs_std_types.c:EXPORT_SYMBOL(uverbs_destroy_def_handler); Need to go into some 'ib_core uverbs support' .c file in the ib_core, be moved to a header inline, or moved otherwise Maybe it is now unrealistic that the uapi is so complicated, ie uverbs_close_fd is just not easy to fixup.. Maybe the only ones that need fixing are ib_uverbs_get_ucontext_file rdma_user_mmap_io as alot of drivers are entangled on those now. The other stuff is much harder.. Jason
